Recurring Footer on quotes

cornelinux · January 29, 2017, 8:54pm

I see, that I can not print any “footer” on quotes. Footers to me are recurring information on each page.
Looking at the code, I indeed see that the function setHTMLFooter is only called for invoices.

github.com

InvoicePlane/InvoicePlane/blob/master/application/helpers/mpdf_helper.php#L62


      
          $mpdf->autoArabic = true;
          $mpdf->autoLangToFont = true;
          
          if (IP_DEBUG) {
              // Enable image error logging
              $mpdf->showImageErrors = true;
          }
          
          // Include zugferd if enabled
          if ($zugferd_invoice) {
              $CI->load->helper('zugferd');
              $mpdf->PDFA = true;
              $mpdf->PDFAauto = true;
              $mpdf->SetAdditionalXmpRdf(zugferd_rdf());
              $mpdf->SetAssociatedFiles($associated_files);
          }
          
          // Set a password if set for the voucher
          if (!empty($password)) {
              $mpdf->SetProtection(array('copy', 'print'), $password, $password);
          }

Is there a specific reason for that?

I would like to have a similar footer on quotes.

What does this mean:
https://development.invoiceplane.com/browse/IP-267
https://community2.invoiceplane.com/t/pdf-footer-for-quotes/789
https://development.invoiceplane.com/browse/IP-309 → it states to be resolved but it is not in 1.4.10.

Kind regards
Cornelius

cornelinux · January 29, 2017, 9:05pm

Oh I see, this was changed in the development branch.

github.com

InvoicePlane/InvoicePlane/blob/development/application/helpers/mpdf_helper.php#L51


    mkdir('./uploads/archive/', '0777');
}


$CI = &get_instance();
if ((strpos($filename, lang('invoice')) !== false OR strpos($filename,
            lang('quote')) !== false) && !empty($CI->mdl_settings->settings['pdf_invoice_footer'])
) {
    $mpdf->setAutoBottomMargin = 'stretch';
    $footerHTML = '<div id="footer">' . $CI->mdl_settings->settings['pdf_invoice_footer'] . '</div>';
    $footerHTML .= '<div class="footer-including-page-number">' . lang('page') . ' {PAGENO} / {nb}</div>';
    $mpdf->SetHTMLFooter($footerHTML);
} else {
    $mpdf->SetHTMLFooter('<div id="footer" class="footer-including-page-number">' . lang('page') . ' {PAGENO} / {nb}</div>');
}
$invoice_array = array();
$mpdf->WriteHTML($html);


if ($stream) {
    if (!$isInvoice) {
        return $mpdf->Output($filename . '.pdf', 'I');
    }

When will this be released?

Kovah · January 29, 2017, 9:42pm

I forgot to add a not on this issue. I would prefer to have different settings for invoice and quote PDFs. So the change from the 1.5.0 branch needs to be copied into the 1.4.11 branch and extended with a new setting for quotes.