Error in pdf templates city/zip?

Support
1

Hello,

there are these strings in Invoice and Quote tempaltes:

    if ($invoice->user_city && $invoice->user_zip) {
        echo '<div>' . $invoice->user_city . ' ' . $invoice->user_zip . '</div>';
    } else {
        if ($invoice->user_zip) {
            echo '<div>' . $invoice->user_zip . '</div>';
        }
        if ($invoice->user_zip) {
            echo '<div>' . $invoice->user_zip . '</div>';
        }
    }

user_zip is called two times, maybe it should be:

    if ($invoice->user_city && $invoice->user_zip) {
        echo '<div>' . $invoice->user_city . ' ' . $invoice->user_zip . '</div>';
    } else {
        if ($invoice->user_city) {
            echo '<div>' . $invoice->user_city . '</div>';
        }
        if ($invoice->user_zip) {
            echo '<div>' . $invoice->user_zip . '</div>';
        }
    }

Is it right?

2

This was alreqdy reported in Some General Errors

1 Like